-
-
Notifications
You must be signed in to change notification settings - Fork 52
Feature/more filter types #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...Filter into new namespace & adding valid filter operators
@johguentner What do you think about this approach for filters in general?
Usage:
$textFilter = Filter::textFilter("Name", "equals", "Ada Lovelace");
@johguentner What do you think about this approach for filters in general?
Usage:
$textFilter = Filter::textFilter("Name", "equals", "Ada Lovelace");
Love it !
What do you think about adding short textFilters as well, like "=" or ">=", or do you think, this would be confusing, since it's the same functionality ? 🤔
If I had to choose one, I'd actually stick with words like "equals", since it's more Notion-like 👌
Hmm, I would stick with the Notion terms (so equals instead of =). Maybe we can think about shorthands ::numberGreaterThan($value, $prop) or something later 🤔
I also added constants for the values in the Operators class for typo-safety. We should move them to an enum as soon as PHP 8.1 is widely distributed :)
No description provided.